Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • sac2c sac2c
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 394
    • Issues 394
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 16
    • Merge requests 16
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sac-group
  • sac2csac2c
  • Merge requests
  • !107

Extend modulo primitive to support all "whole number" types

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hans-Nikolai Viessmann requested to merge sbs/sac2c:giacomos-damn-modulo-on-long into develop Mar 27, 2019
  • Overview 3
  • Commits 3
  • Pipelines 2
  • Changes 5

This MR extends _mod_SxS_ primitive to support all whole number types, e.g. byte, short, int, long, longlong, and there unsigned equivalents. Previously only int was supported.

This MR additionally,

  • adds a test to make sure _mod_SxS_ works correctly.
  • adds an error (abort) message to the unimplemented function for performing modulo on scalars and vectors. Previously this would not fail, leading to undefined behaviour.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: giacomos-damn-modulo-on-long