Skip to content

Extend modulo primitive to support all "whole number" types

Hans-Nikolai Viessmann requested to merge sbs/sac2c:giacomos-damn-modulo-on-long into develop

This MR extends _mod_SxS_ primitive to support all whole number types, e.g. byte, short, int, long, longlong, and there unsigned equivalents. Previously only int was supported.

This MR additionally,

  • adds a test to make sure _mod_SxS_ works correctly.
  • adds an error (abort) message to the unimplemented function for performing modulo on scalars and vectors. Previously this would not fail, leading to undefined behaviour.

Merge request reports