Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • sac2c sac2c
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 394
    • Issues 394
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sac-group
  • sac2csac2c
  • Merge requests
  • !83

Don't generate sac.h, create it manually with appropriate ifdefs.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Artem Shinkarov requested to merge tema/sac2c:fix-sac-h into develop Oct 23, 2018
  • Overview 8
  • Commits 1
  • Changes 4

Currently, sac.h is being generated within the cmake call. The generation process simply takes all the runtime or libsac headers and puts #include <file> in sac.h.

The resulting file consists of ~100 includes which are traversed by a preprocessor every time we compile a sac program. Even thought this takes little time in the overall sac compilation, it becomes noticeable when using sac2c from jupyter notebooks, where we quickly compile small programs.

Therefore when compilation speed is important, it is better no to traverse all these files, so we include the headers conditionally.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-sac-h