Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • sac2c sac2c
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 400
    • Issues 400
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sac-group
  • sac2csac2c
  • Merge requests
  • !416

Generate _tp_impl for externals with varargs and use _tp_impl functions in `usesymbols`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jordy Aaldering requested to merge tp-flags into develop Jun 10, 2025
  • Overview 0
  • Commits 10
  • Changes 4

Changes:

  • importsymbols No need to import impl if type patterns are disabled.
  • usesymbols If type patterns enabled, make both the function itself and the impl variant available.
  • type_pattern_resolve If an external function has varargs (...), simply duplicate it and rename it to the impl function for now. We do this because we always assume that both foo and _tp_impl_foo are available if type patterns are enabled. Handling these cases requires passing of ... or __va_args__ in the SaC world, which is non-trivial.
  • rterror No point in inlining conditionalAbort, this is not performance-critical anyways but would produce a lot of inlined code.
Edited Jun 10, 2025 by Jordy Aaldering
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: tp-flags