Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • sac2c sac2c
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 400
    • Issues 400
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sac-group
  • sac2csac2c
  • Merge requests
  • !273

Resolve "UAR crashes when called in WL"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jordy Aaldering requested to merge 2373-uar-wl-crash into develop Feb 01, 2024
  • Overview 0
  • Commits 4
  • Changes 5

The problem was that the reference counting traversal inserted counting on dummy arguments that are later removed, leading to references to deleted nodes.

This was only being avoided for a single specific case, instead of for all occurrences.

  • Applications of NLUTincNum have been wrapped in a static function IncNum, which does nothing if the avis is a dummy.
  • AdjustRC has been modified to ignore dummy avises.

This ensures that we now properly ignore reference counting for dummy values in all cases.

Closes #2373 (closed)

Side note: UAR is enabled by default, so the -douar flag is no longer required

Edited Feb 01, 2024 by Jordy Aaldering
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 2373-uar-wl-crash