Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • sac2c sac2c
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 334
    • Issues 334
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • Deployments
    • Deployments
    • Releases
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sac-group
  • sac2csac2c
  • Merge requests
  • !135

Hotfix for several bugs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sven-Bodo Scholz requested to merge sbs/sac2c:hotfix-audgz-bug into develop Dec 04, 2020
  • Overview 3
  • Commits 10
  • Changes 13

This fix actually fixes at least four bugs:

  1. One of them was a mistake switching compile from old types to new types.
  2. A second bug was an undetected error in TYgetShape which would return "partial shapes" for AKD types. However, this future extension is not supported in the type checker at all, just in new_types.c. As a result, we plainly got wrong shapes in undetected AKD cases.
  3. The third bug was the fact that wet:WLTRA expects all bounds to be structural constants. We have a phase that ensures just that (wlbsc). This phase was not run directly before WLTRA and some intermediate phase would lift the structural constants out again.... added a run of wlbsc directly before WLTRA now
  4. The fourth bug was that WLTRA expects all empty generator of AKS and AKD WLs to be gone. Unfortunately, wlsimp, the phase that guarantees that, did not elide empty generators if they were thee only ones in an AKD WL. This has now been fixed (cf. issue #2255 (closed))
Edited Dec 04, 2020 by Hans-Nikolai Viessmann
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hotfix-audgz-bug