Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • sac2c sac2c
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 393
    • Issues 393
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 24
    • Merge requests 24
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sac-group
  • sac2csac2c
  • Merge requests
  • !111

Incorporate generic building

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hans-Nikolai Viessmann requested to merge hans/sac2c:hans-fix-buildgeneric into develop Sep 05, 2019
  • Overview 13
  • Commits 4
  • Changes 12

We have had issues with the build system using mtune=native to compile the libsac2c and the runtime libraries, making it impossible to create distributable packages without it breaking due to ISA incompatibilities.

Changing the build system to not use mtune=native is doable, but involves having to filter out the mtune=native flag at the right points in the build. Additionally, when using different C compilers (such as with NVCC) we need to account for this, which may require a different solution for each compiler. This is non-trivial to achieve as in some instances the compiler is not applicable to build sac2c, but only a runtime lib or two.

This MR uses a different method, which encodes the mtune=native flag into sac2crc and adds a sac2c flag (-generic) to toggle the effect. The advantage here is that we can define different flags for different SBIs, without affecting the build system. Furthermore, the changes to the build system are minimal, which involves propagating the flags to sac2crc and change whether libsac2c is built with mtune=native or not.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hans-fix-buildgeneric