Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • sac2c sac2c
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 394
    • Issues 394
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 25
    • Merge requests 25
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • sac-group
  • sac2csac2c
  • Merge requests
  • !110

remove -pedantic flag from cmake

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Hans-Nikolai Viessmann requested to merge hans/sac2c:hans-develop into develop Sep 04, 2019
  • Overview 5
  • Commits 2
  • Changes 2

When building sac2c on different *UNIX distros, our use of vardic macros causes GCC to spit out tons and tons of warnings when using the -pedantic flag.

Compilers like Clang emulate this behavior but provide a flag to suppress the warnings: -Wno-gnu-zero-variadic-macro-arguments.

At somepoint, GCC adopted this flag but it seems not to be standard, as most distros (even with newer version of GCC) do not support this flag.

This commit removes the -pedantic flag from the build flags, this allows us to retain some of our macros without ill-effect. However this means that sac2c is not built to strictly conform to C standard (though -pedantic does not garantee this anyway). Given that most C compilers all share the same feature sets and extensions, it seems unnessicary to include this anymore.

We still use -pedantic in the SAC compiler flags.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: hans-develop